Skip to content

fix(list,grid,detail,tree,core): 消费者收敛到单键 — 列身份家族归零 (#3104 PR2) - #3122

Merged
os-zhuang merged 1 commit into
mainfrom
claude/identity-dual-read-field-priority-h5crvu
Jul 31, 2026
Merged

fix(list,grid,detail,tree,core): 消费者收敛到单键 — 列身份家族归零 (#3104 PR2)#3122
os-zhuang merged 1 commit into
mainfrom
claude/identity-dual-read-field-priority-h5crvu

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

#3104 PR2(消费者收敛)。接 #3119(PR1,已合)。台账:objectstack#4115。

PR1 的 chokepoint 盖不到的地方,才是这一件的用户价值

PR1 把归一挂在 normalizeListViewSchema —— ListView 的组件边界。但独立渲染的 object-grid 节点(页面直接 author 一个 grid,上面没有 list-view)从不经过那道 fold。ObjectTreeRelatedListrecord:details / record:related_list 同理。

ObjectGrid 的自相矛盾在这些表面上就是活的:

const ensureId = (list) => {
  const names = list.map(f => f?.name || f?.field);   // 探针:name 优先
  
};
const fields = schemaColumns.map(c => c.field);        // 投影:只读 field

于是 { name: 'account' } 这样一列进到 $select 里是一个字面的 undefined 空洞 —— 服务端根本不返回该字段,那一列每个格子都是空的。测试里的失败信息把它照了出来:

AssertionError: expected [ 'id', undefined ] to include 'account'

收敛

表面 原读法 现在
ListView ×9 + 它的 2 个请求构造器 name || fieldName || field vs f?.field columnIdentity()
RelatedList ×8 accessorKey || field || name accessorKey || columnIdentity()
ObjectGrid(探针 + 投影) name 优先 vs 只读 field columnIdentity()
ObjectTree name || fieldName || field || key columnIdentity() || key
buildExpandFields field ?? name ?? fieldName columnIdentity()
record-details / record-related-list field || name (|| key) columnIdentity() (|| key)

accessorKey 保住优先级 —— 它是 TanStack Table 的列键,不是 ObjectStack 元数据身份,只有 field || name 那截被收敛(而且保留 || 而非 ??,空串的 fall-through 语义原样保留)。keyObjectTree / record-related-list 里同样留作尾部兜底:它是通用条目键。

两个 TypeScript 顺手挖出来的既有缺陷

resolver 不再返回 any 之后,tsc 立刻指出 ListView 有两处会构造出 value: undefined / name: undefined 的条目(筛选字段下拉 + hide-fields 弹层)—— 对「没有可解析身份」的列。这种条目永远匹配不上任何一列,现在直接丢弃。不是我引入的,是原来 f.name || f.fieldName || f.fieldany 把它藏住了。

盘点再分流:24 → 22 → 0

PR1 记了 24 个家族成员。读清楚它们实际喂给谁之后,有两处是我分流错了,这里改判而不是收敛 —— 它们根本不是列读取:

所以家族实际是 22,现在是 0。ratchet 从 34 降到 12(全部非家族residue)。

ratchet 现在钉三件事

  1. 家族计数 = 0,总数 = 12(新增双读、或已列文件里多一处 → 红;变少也红)。
  2. 每个收敛过的表面确实走了共享 reader —— 如果哪个表面不是「收敛」而是「悄悄把身份解析删了」,这条会红。
  3. RelatedListaccessorKey 仍在 columnIdentity 之前(source-level pin,注释里明写它是 source-level 而不是行为断言)—— 这条一旦破,导入的 TanStack 列会全部解析不出来、整列变空。

mutation-test

变异 闸门 结果
M4 把 ObjectGrid 的投影改回 c.field columnIdentity.test.tsx 🔴 expected [ 'id', undefined ] to include 'account'

(PR1 的 M1/M2/M3 仍在,ratchet 与复现测试未变。)

验证

vitest  core + plugin-list/grid/detail/tree/view  →  166 files / 2344 tests 全绿
turbo   type-check ×5 包                          →  17/17 successful
eslint  改动文件 --quiet                           →  0 error

PR1 的复现测试(ListView.columnIdentity.test.tsx)继续绿 —— 现在它同时覆盖 fold 和收敛后的读法两条保障。

破坏面

全部 patch。仓内行为变化只发生在「同一列两个键不一致」和「非 ListView 下游表面的遗留单键列」上 —— 前者是缺陷,后者是修复(原来那列是空的)。

后续(PR3)

闸门 + 响亮化:hasConflictingColumnIdentity 已在 PR1 就位待用;fold 从镜像改为删除;台账条目处置,同步 objectstack#4115。

关联:#3119(PR1)、objectstack#4115(台账)、#3090(判别法)、#2598(chokepoint 先例)。


Generated by Claude Code

…3104 PR2)

PR1 (#3119) put a canonicalizing fold at ListView's ingestion boundary. This
converges the 22 read sites themselves onto `columnIdentity()`, so a surface
that is NOT downstream of that fold resolves the same identity anyway.

That distinction is the user-visible part. A standalone `object-grid` node —
authored directly on a page, with no `list-view` above it — never passed
through `normalizeListViewSchema`. Its `getSelectFields` read `c.field` alone
while the `ensureId` probe one line above read `f?.name || f?.field`, so a
legacy `{name:'account'}` column reached `$select` as a literal `undefined`
hole: the server never returned the field and every cell in that column came
back empty. Same for ObjectTree, RelatedList and the record:details /
record:related_list renderers.

Converged:
  ListView ×9 + its 2 request builders  ->  columnIdentity()
  RelatedList ×8                        ->  accessorKey || columnIdentity()
  ObjectGrid (probe + projection)       ->  columnIdentity()
  ObjectTree                            ->  columnIdentity() || key
  buildExpandFields                     ->  columnIdentity()
  record-details / record-related-list  ->  columnIdentity() (|| key)

`accessorKey` keeps its precedence in RelatedList — it is TanStack Table's
column key, not ObjectStack metadata identity, and only the `field || name`
tail was converged. `key` stays a tail fallback in ObjectTree and
record-related-list for the same reason: it is a generic entry key.

Two incidental fixes TypeScript surfaced once the resolver stopped returning
`any`: ListView's filter-field options and its hide-fields popover both built
entries keyed `undefined` for a column with no resolvable identity. Those
entries could never match a column; they are now dropped.

Inventory re-triage: PR1 recorded 24 family members. Two were mis-classified
and are reclassified rather than converged — reading what they actually feed
shows they are not column reads at all. ViewPreview adapts a ViewItem FORM
section to what object-form selects by (#3090's two-layer join); SchemaForm
renders an arbitrary metadata ARRAY into a popover summary and guesses at a
display key. So the family was 22, and it is now 0.

The ratchet asserts that, asserts each converged surface actually routes
through the shared reader (a surface that dropped identity resolution instead
of converging it goes red), and pins accessorKey's precedence in RelatedList.

Refs: objectstack#4115, #3090 (playbook), #3119 (PR1)

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C2pdPmf2yZSd4wFDs1NHY5
@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 31, 2026 11:45am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.1 KB 350 KB
Entry file index-B4ZmKpN9.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.26KB 2.99KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.35KB 1.07KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 474.90KB 104.10KB
core (index.js) 2.25KB 0.80KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 136.20KB 34.74KB
fields (index.js) 222.06KB 54.35KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.44KB 10.66KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.05KB 1.53KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 8.75KB 3.06KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 60.52KB 17.11KB
plugin-chatbot (index.js) 180.09KB 42.72KB
plugin-dashboard (index.js) 111.59KB 28.74KB
plugin-designer (index.js) 210.51KB 42.50KB
plugin-detail (index.js) 222.19KB 54.46KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 111.38KB 26.93KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 183.29KB 48.56KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 104.62KB 25.18KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 40.32KB 10.53KB
plugin-timeline (index.js) 25.75KB 7.32KB
plugin-tree (index.js) 8.34KB 2.82KB
plugin-view (index.js) 83.54KB 20.39KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-retry.js) 4.32KB 2.02KB
types (index.js) 2.45KB 1.21KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 1.08KB 0.64KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 31, 2026 12:02
@os-zhuang
os-zhuang merged commit 95b7214 into main Jul 31, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/identity-dual-read-field-priority-h5crvu branch July 31, 2026 12:02
os-zhuang added a commit that referenced this pull request Jul 31, 2026
…3124)

Closes the battle opened in #3104. PR1 (#3119) put the canonicalizing fold at
ingestion; PR2 (#3122) converged all 22 read sites onto columnIdentity(). This
is the audible half.

A column carrying two identity keys that DISAGREE now logs a one-time dev-mode
warning naming which key won and what to change. The fold making the two halves
agree is what stops the bug, but silently rewriting `name` to match `field`
also hides that the producer is emitting a contradiction. The renderer
recovering is not the same as the metadata being right, so the recovery says so.

Deliberately narrow:
  - Only contradictions. `{name:'stage'}` is legacy, not conflicting — stamped
    without noise.
  - Warn once per (identity, conflicting spelling). Columns are re-normalized on
    every render, and a warning that floods the console is one that gets muted.
    Keyed by the pair rather than the identity alone, so a column carrying two
    different stale spellings reports both.
  - Silent under NODE_ENV=production, and the fold still runs there.

No lint rule, and that is a measured decision. #3104 asked for
no-restricted-syntax on `.field ?? .name` to be evaluated on its false-positive
rate first. With the family at zero, all 12 remaining scanner hits are
legitimate — a syntactic rule cannot tell a two-layer join from a dual read,
because the distinction is what the keys MEAN in that layer, not how the
expression is spelled. Adopting it would mean 12 inline disables on correct
code, which trains the next author to reach for the disable. The ratchet carries
a verdict and a why per site instead. The evaluation is written into its header.

Ledger item resolved with no change needed: #3104 flagged ListColumn for
disposition under objectstack#4115 (spec-named symbols must be imports, not
declarations). ListColumnSchema is already a by-reference re-export of
@objectstack/spec/ui, and spec-subschema-parity.test.ts already pins it by
reference identity — the only check that distinguishes a re-export from a
faithful fork. Already compliant.

Verified: M5 (drop the warn call) turns 4 of the new tests red.
  vitest core+list+grid+detail+tree+view+types -> 188 files / 2663 tests green
  vitest app-shell                             -> 250 files / 2089 tests green
  turbo type-check, eslint                     -> green

Refs: objectstack#4115, #3090 (playbook), #3119 (PR1), #3122 (PR2)


Claude-Session: https://claude.ai/code/session_01C2pdPmf2yZSd4wFDs1NHY5

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants